Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Remove extraneous parameter from removeObject API #188

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[v8] Remove extraneous parameter from removeObject API #188

merged 1 commit into from
Jun 11, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 11, 2024 •
edited
Loading

Address #187 (comment)

@ncooke3 ncooke3 mentioned this pull request Jun 11, 2024
Merged
@ncooke3 ncooke3 requested review from paulb777 and andrewheard June 11, 2024 18:33
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.62% (cb3d41f) to 0.13% (97096bf) by -0.49%.

    FilenameBase (cb3d41f)Merge (97096bf)Diff
    GULAppEnvironmentUtil.m3.23%3.42%+0.20%
    GULNetworkInfo.m23.86%0.00%-23.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Yeic9WaTL0.html

@ncooke3 ncooke3 merged commit b5c37c5 into nc/remove-promises Jun 11, 2024
19 checks passed
@ncooke3 ncooke3 deleted the nc/remove-promises-6 branch June 11, 2024 21:02
ncooke3 added a commit that referenced this pull request Jun 11, 2024
@ncooke3
[v8] Remove dependency on the Promises SDK (#187)
2771466 
* [v8] Replace read keychain API with completion handler based API (#182)

* [v8] Replace write keychain API with completion handler based API (#183)

* [v8] Replace remove keychain API with completion handler based API (#184)

* [v8] Replace remove keychain API with completion handler based API

* Update GoogleUtilities/Environment/SecureStorage/GULKeychainStorage.m

* [v8] Fix tests, docs, and imports following `GULKeychainStorage` API changes (#185)

* [v8] Remove Promises API and dependency specifications (#186)

* [v8] Remove Promises API and dependency specifications

* Remove other header

* [v8] Add changelog for removal of Promises dependency

* [v8] Remove extraneous parameter from removeObject API (#188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard Awaiting requested review from andrewheard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @google-oss-bot @paulb777