Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visionOS] Fix GULReachabilityCheckerTest in Xcode 15.1 beta 1 #133

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[visionOS] Fix GULReachabilityCheckerTest in Xcode 15.1 beta 1 #133

merged 1 commit into from
Oct 11, 2023

Conversation

andrewheard
Copy link
Collaborator

In Xcode 15.1 TARGET_OS_IOS is now 0 instead of 1. This PR fixes GULReachabilityCheckerTest when running on the Apple Vision Pro simulator.

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

No changes between base commit (4780d5c) and merge commit (5cb8976).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xG4MIZ5dIZ.html

@andrewheard andrewheard marked this pull request as ready for review October 11, 2023 21:19
@andrewheard andrewheard merged commit 4ef9a64 into main Oct 11, 2023
20 checks passed
@andrewheard andrewheard deleted the ah/visionos-reachability branch October 11, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewheard @google-oss-bot @paulb777 @ncooke3