Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Migrate ISASwizzler to Firebase Performance #190

Merged
merged 3 commits into from
Jun 17, 2024
Merged

[v8] Migrate ISASwizzler to Firebase Performance #190

merged 3 commits into from
Jun 17, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 15, 2024 •
edited
Loading

Migrate ISASwizzler to Firebase Performance since it is the only client and we don't want to do additional swizzling.

Corresponding Firebase PR is firebase/firebase-ios-sdk#13137

@paulb777 paulb777 mentioned this pull request Jun 15, 2024
Merged
@google-oss-bot
Copy link

google-oss-bot commented Jun 15, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.62% (cb3d41f) to 0.14% (c10200a) by -0.49%.

    FilenameBase (cb3d41f)Merge (c10200a)Diff
    GULAppEnvironmentUtil.m3.23%3.42%+0.20%
    GULNetworkInfo.m23.86%0.00%-23.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6WIYzP2A3D.html

@paulb777 paulb777 requested review from ncooke3 and visumickey June 17, 2024 13:33
@paulb777 paulb777 changed the title Migrate ISASwizzler to Firebase Performance [v8] Migrate ISASwizzler to Firebase Performance Jun 17, 2024
@paulb777 paulb777 merged commit 8a0d06d into release-8.0 Jun 17, 2024
19 checks passed
@paulb777 paulb777 deleted the pb-mv-isa-swizzler branch June 17, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@visumickey visumickey visumickey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulb777 @google-oss-bot @visumickey @ncooke3