-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from ASL
to OSLog
#192
Conversation
Coverage Report 1Affected Products
Test Logs |
@andrewheard, as far as outstanding TODOs for this PR, it's mainly to add back the existing public API to make this non-breaking, right? Anything else? |
@ncooke3 This now has the existing public API to make it non-breaking but still need to fix the tests. Better names for the new APIs would also be good. |
# Conflicts: # GoogleUtilities/UserDefaults/GULUserDefaults.m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's sort out whether or not we need the deprecated functions and then LGTM
Migrated from
ASL
toOSLog
inGULLogger
but retained the existing API (now deprecated) for backwards compatibility.