Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from ASL to OSLog #192

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Migrate from ASL to OSLog #192

merged 7 commits into from
Jul 11, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Jun 18, 2024

Migrated from ASL to OSLog in GULLogger but retained the existing API (now deprecated) for backwards compatibility.

@google-oss-bot
Copy link

google-oss-bot commented Jun 18, 2024

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.14% (83fa5a9) to 0.14% (ed612a5) by -0.00%.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AE8jKZbFME.html

@ncooke3
Copy link
Member

ncooke3 commented Jun 27, 2024

@andrewheard, as far as outstanding TODOs for this PR, it's mainly to add back the existing public API to make this non-breaking, right? Anything else?

@andrewheard
Copy link
Collaborator Author

andrewheard commented Jun 28, 2024

as far as outstanding TODOs for this PR, it's mainly to add back the existing public API to make this non-breaking, right? Anything else?

@ncooke3 This now has the existing public API to make it non-breaking but still need to fix the tests. Better names for the new APIs would also be good.

@andrewheard andrewheard added this to the GoogleUtilities 8.0.0 milestone Jul 2, 2024
@andrewheard andrewheard requested review from paulb777 and ncooke3 July 2, 2024 15:17
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's sort out whether or not we need the deprecated functions and then LGTM

GoogleUtilities/Logger/GULLogger.m Show resolved Hide resolved
GoogleUtilities/Logger/Public/GoogleUtilities/GULLogger.h Outdated Show resolved Hide resolved
@andrewheard andrewheard changed the base branch from release-8.0 to main July 9, 2024 15:41
@andrewheard andrewheard merged commit 3cd2e3d into main Jul 11, 2024
21 checks passed
@andrewheard andrewheard deleted the ah/oslog-migration branch July 11, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants