-
Notifications
You must be signed in to change notification settings - Fork 204
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix flame graphs for Chromium's perl
The version of perl that ships with Chromium's depot_tools can't handle CRLF endings on text files, so I've modified xperf_to_collapsedstacks.py to write the collapsed stacks in binary mode. Also, there was a missing parameter to a format-string function.
- Loading branch information
1 parent
e7d5849
commit 311717f
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1891,7 +1891,7 @@ void CUIforETWDlg::CreateFlameGraph(const std::wstring& traceFilename) | |
{ | ||
outputPrintf(L"\nCreating CPU Usage (Sampled) flame graph of busiest process in %s " | ||
L"(requires python, perl and flamegraph.pl). UIforETW will hang while " | ||
L"this is calculated...\n"); | ||
L"this is calculated...\n", traceFilename.c_str()); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
randomascii
Author
Contributor
|
||
std::wstring pythonPath = FindPython(); | ||
if (!pythonPath.empty()) | ||
{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huh...
/analyze
missed this?