Skip to content

Commit

Permalink
Build binaries instead of using committed ones
Browse files Browse the repository at this point in the history
Checked in binaries can be a security issue and can also lead to binary
rot - projects that will no longer build. This change removes the
dependency on pre-built binaries that are actually built from this repo.

This mostly fixes issue #155.
  • Loading branch information
randomascii committed Jul 27, 2022
1 parent dd2c713 commit ea32da8
Show file tree
Hide file tree
Showing 9 changed files with 17 additions and 0 deletions.
Binary file removed bin/DummyChrome.dll
Binary file not shown.
Binary file removed bin/ETWProviders.dll
Binary file not shown.
Binary file removed bin/ETWProviders64.dll
Binary file not shown.
Binary file removed bin/ETWProvidersARM64.dll
Binary file not shown.
Binary file removed bin/RetrieveSymbols.exe
Binary file not shown.
Binary file removed lib/ETWProviders.lib
Binary file not shown.
Binary file removed lib/ETWProviders64.lib
Binary file not shown.
Binary file removed lib/ETWProvidersARM64.lib
Binary file not shown.
17 changes: 17 additions & 0 deletions package_etw.bat
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,23 @@ cd /d %UIforETW%ETWInsights
devenv /rebuild "release|Win32" ETWInsights.sln
@if ERRORLEVEL 1 goto BuildFailure
xcopy Release\flame_graph.exe %UIforETW%\bin /y
cd /d %UIforETW%

@echo Building DummyChrome (DLL for registering Chrome ETW events)
devenv /rebuild "release|Win32" DummyChrome\DummyChrome.sln
@if ERRORLEVEL 1 goto BuildFailure

@echo Building ETWProviders (three versions)
devenv /rebuild "release|Win32" ETWProviders\ETWProviders.sln
@if ERRORLEVEL 1 goto BuildFailure
devenv /rebuild "release|x64" ETWProviders\ETWProviders.sln
@if ERRORLEVEL 1 goto BuildFailure
devenv /rebuild "release|arm64" ETWProviders\ETWProviders.sln
@if ERRORLEVEL 1 goto BuildFailure

@echo Building RetrieveSymbols
devenv /rebuild "release|Win32" RetrieveSymbols\RetrieveSymbols.sln
@if ERRORLEVEL 1 goto BuildFailure

cd /d %UIforETW%UIforETW
@rem Modify the UIforETW project to be statically linked and build that version
Expand Down

0 comments on commit ea32da8

Please sign in to comment.