chore: add blockly-react-ts example #1999
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Add a vite + typescript example in blockly-react-ts
Reason for Changes
This can be used to test build issues related to vite.
Please also refer to #1679 to see if this example is useful to the team and whether it should replace the existing blockly-react example.
Test Coverage
N/A. We don't have a good way to unit test /examples. In the future we can use a browser test via playwright or a similar solution.
Documentation
N/A
Additional Information
cc @maribethb
According to https://github.com/nbudin/react-blockly the core maintainer has no longer uses blockly on a day-to-day basis, that being said a recent version of this library was just released a week ago so it's definitely not abandoned.
IMO these examples are useful in the short term to test things like different builds. Longer term it might make sense to do some e2e tests with selenium/playwright. Also things like codesandbox integration might be interesting:
For example this link opens up the codesandbox:
https://githubbox.com/alicialics/blockly-samples/tree/blockly-react-ts/examples/blockly-react-ts
this opens in stackblitz
https://stackblitz.com/github/alicialics/blockly-samples/tree/blockly-react-ts/examples/blockly-react-ts