Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workspace shifts when deleting a block #8666

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: workspace shifts when deleting a block #8666

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dffa3dd
fix: workspace shifts when deleting a block
mateusslezinsky Nov 18, 2024
839c691
Merge branch 'google:develop' into develop
mateusslezinsky Nov 26, 2024
8b0c04b
fix: awaiting for block rerender
mateusslezinsky Nov 27, 2024
7827fb4
Merge remote-tracking branch 'origin/develop' into develop
mateusslezinsky Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/dragging/block_drag_strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ export class BlockDragStrategy implements IDragStrategy {
* Cleans up any state at the end of the drag. Applies any pending
* connections.
*/
endDrag(e?: PointerEvent): void {
async endDrag(e?: PointerEvent): Promise<void> {
if (this.block.isShadow()) {
this.block.getParent()?.endDrag(e);
return;
Expand All @@ -385,7 +385,7 @@ export class BlockDragStrategy implements IDragStrategy {
// Applying connections also rerenders the relevant blocks.
this.applyConnections(this.connectionCandidate);
} else {
this.block.queueRender();
await this.block.queueRender();
}
this.block.snapToGrid();

Expand Down