Allow public fields with the @final JsDoc to be assigned once insid…

…e a constructor.

Originally, the `CheckAccessControls` pass did not support field assignment inside of a constructor and would throw the `JSC_FINAL_PROPERTY_OVERRIDEN` error. We now allow unassigned public fields with the `@final` JsDoc to be assigned once in the constructor. Allowing public fields to be recognized puts the team closer to flipping the flag to turn on public fields for google3.

PiperOrigin-RevId: 553601386

src/com/google/javascript/jscomp/CheckAccessControls.java

@@ -1368,7 +1368,7 @@ public final String getReadableTypeNameOrDefault() {
               builder
                   .setName(sourceNode.getString())
                   .setReceiverType(typeRegistry.getNativeObjectType(JSTypeNative.UNKNOWN_TYPE))
-                  .setMutation(true)
+                  .setMutation(!(sourceNode.isMemberFieldDef() && !sourceNode.hasChildren()))
                   .setDeclaration(true)
                   // TODO(b/113704668): This definition is way too loose. It was used to prevent
                   // breakages during refactoring and should be tightened.

test/com/google/javascript/jscomp/CheckAccessControlsTest.java

@@ -79,6 +79,68 @@ protected CompilerOptions getOptions() {
     return options;
   }
 
+  @Test
+  public void testOverrideAllowed() {
+    testSame(
+        lines(
+            "class Foo {", //
+            "  /** @final*/ x;",
+            "  constructor() {",
+            "    this.x = 5;",
+            "  }",
+            "}"));
+  }
+
+  @Test
+  public void testMultipleFieldsOverrideAllowed() {
+    testSame(
+        lines(
+            "class Bar {", //
+            "  /** @final*/ a;",
+            "  /** @final */ b;",
+            "  constructor() {",
+            "    this.a = 1;",
+            "    this.b = 2;",
+            "  }",
+            "}"));
+  }
+
+  @Test
+  public void testFieldOverrideNotAllowed() {
+    testError(
+        lines(
+            "class Bar {", //
+            "  /** @final*/ a;",
+            "  constructor() {",
+            "    this.a = 1;",
+            "    this.a = 2;",
+            "  }",
+            "}"),
+        FINAL_PROPERTY_OVERRIDDEN);
+
+    testError(
+        lines(
+            "class Bar {", //
+            "  /** @final*/ a = 5;",
+            "  constructor() {",
+            "    this.a = 1;",
+            "  }",
+            "}"),
+        FINAL_PROPERTY_OVERRIDDEN);
+  }
+
+  @Test
+  public void testThisAssignmentInConstructor() {
+    testSame(
+        lines(
+            "class Foo {", //
+            "  constructor() {",
+            "    /** @const {number} */ this.x;",
+            "    this.x = 4;",
+            "  }",
+            "}"));
+  }
+
   @Test
   public void testWarningInNormalClass() {
     test(