Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: correct Travis CI link #232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deining
Copy link

@deining deining commented Apr 1, 2021

This PR

  • correct Travis CI link CONTRIBUTING.md
  • switches from http to https in several locations (license in source file, pom.xml, ...)

Switch from http to https (license in source file, ...)
@google-cla google-cla bot added the cla: yes label Apr 1, 2021
Comment on lines +16 to 18
https://travis-ci.com to validate your branches before you even put them into
pull requests. All pull requests will be validated by Travis CI in any case
and must pass before being merged.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reworked as the project has switched from Travis CI to GitHub Actions.

CONTRIBUTING.md Show resolved Hide resolved
Copy link
Member

@cpovirk cpovirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're up for making the updates that tbroyer suggests, we'd be happy to take those. As noted inline, though, I think we should leave the URLs as they are.

@@ -1,7 +1,7 @@

Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
https://www.apache.org/licenses/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think we're advised to keep the license text exactly as it is. And I notice that even the copy of the license that is served from https (that is, from https://www.apache.org/licenses/LICENSE-2.0) uses http: links.

@cpovirk cpovirk added P4 type=documentation Documentation that is other than for an API labels Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes P4 type=documentation Documentation that is other than for an API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants