Use a more specific function type instead of Function object for Stri…

…ng.prototype.replace callback. PiperOrigin-RevId: 245856963
google · Apr 30, 2019 · bd2bb4a · bd2bb4a
1 parent c27f562
commit bd2bb4a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/java/elemental2/core/BUILD b/java/elemental2/core/BUILD
@@ -18,8 +18,6 @@ load("@com_google_jsinterop_generator//:jsinterop_generator.bzl", "jsinterop_gen
 # TODO(b/36088887): Handle correctly @this annotation
 # Removes non-existing static methods defined in Array type.
 # TODO(b/36088884): clean-up the extern file directly
-# Define better callback for String.replace.
-# TODO(b/62258818): remove this specific patch when the bug is fixed and the extern file is updated.
 # Make RegExp API stricter.
 # TODO(b/38034193): clean up the RegExp API in the extern file directly.
 patch_extern_file(

diff --git a/java/elemental2/core/es3.js.diff b/java/elemental2/core/es3.js.diff
@@ -202,10 +202,6 @@
 < Array.some = function(arr, callback, opt_context) {};
 < 
 < /**
-1888c1773
-<  * @param {string|Function} replacement
----
->  * @param {string|function(string, ...?):*} replacement
 2050c1935
 <  * @param {*} pattern
 ---