-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codecov-action version #3221
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Glenn Lewis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3221 +/- ##
==========================================
- Coverage 97.72% 92.94% -4.78%
==========================================
Files 153 171 +18
Lines 13390 11633 -1757
==========================================
- Hits 13085 10812 -2273
- Misses 215 727 +512
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
This does NOT solve the problem because codecov appears to be using a very old commit as the BASE: After more investigation, I found this thread: However, its "solution" was solved in a private conversation. I'll try adding to the thread. |
Signed-off-by: Glenn Lewis <[email protected]>
According to this: codecov/feedback#123 |
This issue also mentions the codecov token: codecov/feedback#144 |
@google-admin - when you get a chance can you please make sure that this repo's CODECOV secret repo token is up-to-date? According to all the similar issues I could find (linked above), they say that an old CODECOV token could be the cause of it choosing very old (6-months ago) BASE commits to compare against. Thank you! |
Signed-off-by: Glenn Lewis <[email protected]>
@google-admin - when you get a chance can you please make sure that this repo's CODECOV secret repo token is up-to-date? According to all the similar issues I could find (linked above), they say that an old CODECOV token could be the cause of it choosing very old (6-months ago) BASE commits to compare against. Thank you! |
No description provided.