Asynchronously calculate User-Agent #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CocoaPods compiles with warnings as errors, just use the |
bhamiltoncx
force-pushed
the
async-user-agent
branch
from
c3ab108 to
a60c329
Compare
|
Thanks, fixed by migrating all the existing tests and examples to the new
API and adding a new test for the deprecated API which uses the #pragma to
disable the warning.
…On Tue, Jan 23, 2024 at 8:23 AM Thomas Van Lenten ***@***.***> wrote:
CocoaPods compiles with warnings as errors, just use the #pragmas to turn
off the deprecated warnings around the tests calling the now deprecated
apis.
|
thomasvl
reviewed
Jan 23, 2024
bhamiltoncx
force-pushed
the
async-user-agent
branch
from
a60c329 to
693aaa5
Compare
thomasvl
reviewed
Jan 23, 2024
bhamiltoncx
force-pushed
the
async-user-agent
branch
from
693aaa5 to
b8637aa
Compare
bhamiltoncx
force-pushed
the
async-user-agent
branch
from
b8637aa to
f4777d8
Compare
thomasvl
reviewed
Jan 24, 2024
bhamiltoncx
force-pushed
the
async-user-agent
branch
from
f4777d8 to
bcb0439
Compare
|
Sorry, I managed to accidentally close this by force-pushing the wrong commit to my branch. |
thomasvl
approved these changes
Jan 24, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #616 which ensures the User-Agent is always calculated asynchronously by moving the
NSMutableURLRequestcreation onto a new background serial queue.Should also fix #615.
swift testpasses, trying to run more global tests now.