Document and test how ImmutableMap.toImmutableMap behaves when the mergeFunction returns null.
#6826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_580635720
branch
from
2538ffc
to
1916f61
Compare
copybara-service
bot
force-pushed
the
test_580635720
branch
from
1916f61
to
122873d
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document and test how
ImmutableMap.toImmutableMapbehaves when themergeFunctionreturnsnull.(The test is Google-internal for now because we're in the process of reshuffling our
Collectortests to make them run under Android as part of #6567. Also, we skip the test under GWT+J2CL because of a bug in their implementation ofCollectors.toMap.)This addresses the main part of #6824, but I'm keeping the bug open as a prompt to recognize our nullness annotations in the future.
RELNOTES=n/a