Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs script and ref/stdlib.html #1153

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

johnbartholomew
Copy link
Collaborator

Various things that make it easier for me personally to use:

  • Use an HTTPS pull URL (still the SSH push URL). This is because pulling over HTTPS doesn't need authentication but pushing needs me to tap my security key; cloning over HTTPS halves the number of taps I need.

  • Don't require libjsonnet.wasm to exist - we can just keep the existing one from the gh-pages branch if there isn't a newly built one to use.

  • Require running on a TTY and prompt the user for confirmation before the push. Probably not what we want long term but I was running the script a lot to check things and didn't want to actually push then.

Then update docs/ref/stdlib.html by running update_web_content.sh. We might want to get rid of that file; if not then we'll probably need to add an automated check that it's not out of sync with the source stdlib-content.jsonnet.

Various things that make it easier for me personally to use:

- Use an HTTPS pull URL (still the SSH push URL). This is because
  pulling over HTTPS doesn't need authentication but pushing needs
  me to tap my security key; cloning over HTTPS halves the number of
  taps I need.

- Don't require libjsonnet.wasm to exist - we can just keep the existing
  one from the gh-pages branch if there isn't a newly built one to use.

- Require running on a TTY and prompt the user for confirmation before
  the push. Probably not what we want long term but I was running the
  script a lot to check things and didn't want to actually push then.
@johnbartholomew johnbartholomew merged commit f324ff7 into google:master Apr 16, 2024
6 checks passed
@johnbartholomew johnbartholomew deleted the update-docs-script branch April 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant