Skip to content

Commit

Permalink
Fix vertexai_test break.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 688986487
  • Loading branch information
daiyip authored and langfun authors committed Oct 23, 2024
1 parent e6a927d commit bddd008
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions langfun/core/llms/vertexai_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,12 @@ def test_generation_config(self):
stop=['\n'],
),
)
actual = config.to_dict()
# There is a discrepancy between the `property_ordering` in the
# Google-internal version and the open-source version.
actual['response_schema'].pop('property_ordering', None)
self.assertEqual(
config.to_dict(),
actual,
dict(
temperature=2.0,
top_p=1.0,
Expand All @@ -209,7 +213,6 @@ def test_generation_config(self):
'properties': {
'name': {'type_': 'STRING'}
},
'property_ordering': ['name'],
'required': ['name'],
'title': 'Person',
}
Expand Down

0 comments on commit bddd008

Please sign in to comment.