Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLaMA C++ models and Fix PyType warning/errors raised in VS Code #31

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

D-X-Y
Copy link
Contributor

@D-X-Y D-X-Y commented Oct 6, 2023

  • Add a LLaMA C++ model at langfun/core/llms/llama_cpp.py
  • Fix various minor pytype or annotation issues.

Copy link
Collaborator

@daiyip daiyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding LLamaCpp models, Xuanyi! I have put a few comments inline.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #31 (f909534) into main (1ed40e7) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   97.27%   97.20%   -0.08%     
==========================================
  Files          38       39       +1     
  Lines        2860     2894      +34     
  Branches      597      602       +5     
==========================================
+ Hits         2782     2813      +31     
- Misses         31       33       +2     
- Partials       47       48       +1     
Files Coverage Δ
langfun/core/llms/__init__.py 100.00% <100.00%> (ø)
langfun/core/llms/openai.py 94.89% <100.00%> (+0.21%) ⬆️
langfun/core/message.py 100.00% <ø> (ø)
langfun/core/llms/llama_cpp.py 89.65% <89.65%> (ø)

@D-X-Y D-X-Y requested a review from daiyip October 7, 2023 20:17
@daiyip daiyip merged commit 628f9da into google:main Oct 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants