Fix num_examples computation in lf.eval.v2.
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_696362374
branch
2 times, most recently
from
c81a8dd to
499cb08
Compare
copybara-service
bot
changed the title
num_examples computation.num_examples computation in lf.eval.v2.
copybara-service
bot
force-pushed
the
test_696362374
branch
from
499cb08 to
e8114c9
Compare
Previously we first try to get the `num_examples` from input functor as an optimization for example counting, however, some input functors may set `num_examples` to None, in that case, we should count the example by executing the input function. PiperOrigin-RevId: 696370262
copybara-service
bot
force-pushed
the
test_696362374
branch
from
e8114c9 to
d3c5d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
num_examplescomputation inlf.eval.v2.Previously we first try to get the
num_examplesfrom input functor as an optimization for example counting, however, some input functors may setnum_examplesto None, in that case, we should count the example by executing the input function.