Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining lf.eval.v2. #382

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Refining lf.eval.v2. #382

merged 1 commit into from
Dec 20, 2024

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Dec 20, 2024

Refining lf.eval.v2.

  • Rename eval/v2/test_helper.py to eval/v2/eval_test_helper.py, to prevent it from being tracked by pytest.
  • ParallelRunner: Avoid race condition on io_pool between submission and shutdown.

@copybara-service copybara-service bot force-pushed the test_708072443 branch 3 times, most recently from 496ccd1 to f78700e Compare December 20, 2024 05:02
@copybara-service copybara-service bot changed the title Rename eval/v2/test_helper.py to eval/v2/eval_test_helper.py. Refining lf.eval.v2. Dec 20, 2024
@copybara-service copybara-service bot force-pushed the test_708072443 branch 2 times, most recently from 084c340 to 2acff1f Compare December 20, 2024 18:48
- Rename `eval/v2/test_helper.py` to `eval/v2/eval_test_helper.py`, to prevent it from being tracked by pytest.
- ParallelRunner: Avoid race condition on io_pool between submission and shutdown.

PiperOrigin-RevId: 708369332
@copybara-service copybara-service bot merged commit a5d2bbc into main Dec 20, 2024
1 check passed
@copybara-service copybara-service bot deleted the test_708072443 branch December 20, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant