Fix formatting of authorization record. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjevans-google
force-pushed
the
authz-formatting-fix
branch
from
16892ae to
6454140
Compare
Some systems consider `char` to be signed by default, which causes the
system implementation of `printf("%02x", (char)0xd6);` to print
`ffffffd6`, instead of just `d6`. As the nonce almost always has
"negative" bytes, this badly corrupts the record formatting.
Also add a _Static_assert for the exact size of the authorization
record, for good measure.
cjevans-google
force-pushed
the
authz-formatting-fix
branch
from
6454140 to
bf24650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems consider
charto be signed by default, which causes the system implementation ofprintf("%02x", (char)0xd6);to printffffffd6, instead of justd6. As the nonce almost always has "negative" bytes, this badly corrupts the record formatting.Also add a _Static_assert for the exact size of the authorization record, for good measure.