Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLMD: order_by_creation_time on model iteration fails to execute #358

Open
rareddy opened this issue Sep 6, 2024 · 2 comments · May be fixed by google/ml-metadata#203
Open

MLMD: order_by_creation_time on model iteration fails to execute #358

rareddy opened this issue Sep 6, 2024 · 2 comments · May be fixed by google/ml-metadata#203
Labels
bug Something isn't working dependencies Pull requests that update a dependency file lifecycle/stale

Comments

@rareddy
Copy link
Contributor

rareddy commented Sep 6, 2024

Describe the bug
order_by_creation_time on model iteration fails to execute

To Reproduce

case 1:

On an existing model registry if I execute the following Python client code

for version in registry.get_model_versions("FLUX.1-dev").order_by_update_time():
    print(version)

it fails with

ServiceException: (500)
Reason: Internal Server Error
HTTP response headers: <CIMultiDictProxy('Content-Type': 'application/json; charset=UTF-8', 'Vary': 'Origin', 'Date': 'Fri, 06 Sep 2024 17:58:27 GMT', 'Content-Length': '467', 'x-envoy-upstream-service-time': '23', 'Server': 'istio-envoy')>
HTTP response body: code='' message="rpc error: code = Internal desc = mysql_query failed: errno: Expression #1 of ORDER BY clause is not in SELECT list, references column 'model_registry.table_0.create_time_since_epoch' which is not in SELECT list; this is incompatible with DISTINCT, error: Expression #1 of ORDER BY clause is not in SELECT list, references column 'model_registry.table_0.create_time_since_epoch' which is not in SELECT list; this is incompatible with DISTINCT"

case 2:

if I execute the following Python client code

for version in registry.get_model_versions("FLUX.1-dev").order_by_creation_time():
    print(version)

it fails with

ServiceException: (500)
Reason: Internal Server Error
HTTP response headers: <CIMultiDictProxy('Content-Type': 'application/json; charset=UTF-8', 'Vary': 'Origin', 'Date': 'Fri, 06 Sep 2024 18:00:33 GMT', 'Content-Length': '477', 'x-envoy-upstream-service-time': '24', 'Server': 'istio-envoy')>
HTTP response body: code='' message="rpc error: code = Internal desc = mysql_query failed: errno: Expression #1 of ORDER BY clause is not in SELECT list, references column 'model_registry.table_0.last_update_time_since_epoch' which is not in SELECT list; this is incompatible with DISTINCT, error: Expression #1 of ORDER BY clause is not in SELECT list, references column 'model_registry.table_0.last_update_time_since_epoch' which is not in SELECT list; this is incompatible with DISTINCT"

Expected behavior
it return collection as expected by method contract.

Additional context
Check all the functions that return an iterator for the behavior and fix if needs to be in other places and have functional tests to validate the fix.
@rareddy rareddy added the bug Something isn't working label Sep 6, 2024
@isinyaaa isinyaaa mentioned this issue Sep 9, 2024
Open
3 tasks
@tarilabs tarilabs added Area/MR Python client dependencies Pull requests that update a dependency file and removed Area/MR Python client labels Sep 10, 2024
@tarilabs tarilabs changed the title Python Client: order_by_creation_time on model iteration fails to execute MLMD: order_by_creation_time on model iteration fails to execute Sep 10, 2024
@tarilabs
Copy link
Member

I appreciate @isinyaaa the linking from opendatahub-io/ml-metadata#12

but I don't believe that would actually fully fix this issue (#358), since we rely on the upstream MLMD image shared with KFP in the KFMR manifests too:

model-registry/manifests/kustomize/base/model-registry-deployment.yaml

Line 54 in 533d260

image: gcr.io/tfx-oss-public/ml_metadata_store_server:1.14.0

I would also encourage to create opendatahub-io/ml-metadata#12 also upstream.

wdyt?

i.e. the opendatahub-io/ml-metadata#12 is awesome, and thank you, but that will not be sufficient to close this #358

@isinyaaa isinyaaa linked a pull request Sep 13, 2024 that will close this issue
Open
3 tasks
@tarilabs tarilabs mentioned this issue Sep 19, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing order by fields in SELECT statement isinyaaa/ml-metadata
2 participants
@rareddy @tarilabs