Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py: update README #402

Merged
merged 9 commits into from
Sep 19, 2024
Merged

Py: update README #402

merged 9 commits into from
Sep 19, 2024

Conversation

isinyaaa
Copy link
Contributor

Updated legacy notes, comments WIP bug functionality.

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

tarilabs and others added 5 commits September 19, 2024 14:56
@tarilabs @isinyaaa
doc: skip method description until MLMD bug is fixed
e64e9e3 
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
@isinyaaa
py: README: explicit MR connection options
f7a09c7 
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
@isinyaaa
py: README: restore prints
27055e4 
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
@isinyaaa
py: README: add missing import from utils
331b61e 
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
@isinyaaa
py: README: get rid of legacy note
f17cda4 
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: Isabella do Amaral <[email protected]>
Signed-off-by: Isabella do Amaral <[email protected]>
tarilabs
tarilabs reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @isinyaaa some small changes for your considerations?

clients/python/README.md Outdated Show resolved Hide resolved
clients/python/README.md Outdated Show resolved Hide resolved
clients/python/README.md Outdated Show resolved Hide resolved
clients/python/README.md Outdated Show resolved Hide resolved
isinyaaa and others added 4 commits September 19, 2024 15:09
@isinyaaa @tarilabs
Update clients/python/README.md
a7795c6 
Co-authored-by: Matteo Mortari <[email protected]>
Signed-off-by: Isabella Basso <[email protected]>
@isinyaaa @tarilabs
Update clients/python/README.md
387ed6f 
Co-authored-by: Matteo Mortari <[email protected]>
Signed-off-by: Isabella Basso <[email protected]>
@isinyaaa @tarilabs
Update clients/python/README.md
87796a8 
Co-authored-by: Matteo Mortari <[email protected]>
Signed-off-by: Isabella Basso <[email protected]>
@isinyaaa @tarilabs
Update clients/python/README.md
8de396f 
Co-authored-by: Matteo Mortari <[email protected]>
Signed-off-by: Isabella Basso <[email protected]>
@isinyaaa isinyaaa requested a review from tarilabs September 19, 2024 18:11
tarilabs
tarilabs approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @isinyaaa

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 19, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 510b238 into kubeflow:main Sep 19, 2024
4 checks passed
@isinyaaa isinyaaa deleted the push-yuzkzyomkynt branch September 19, 2024 18:12
@tarilabs
Copy link
Member

e64e9e3 related: #358

@tarilabs tarilabs mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarilabs tarilabs tarilabs approved these changes

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@rareddy rareddy Awaiting requested review from rareddy

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@tarilabs tarilabs

Labels
approved Area/MR Python client lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isinyaaa @tarilabs