Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata_store_service_go_proto build error #113

Closed
wants to merge 1 commit into from
Closed

Fix metadata_store_service_go_proto build error #113

wants to merge 1 commit into from

Conversation

guunergooner
Copy link

@guunergooner guunergooner commented Apr 26, 2021

@google-cla
Copy link

google-cla bot commented Apr 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 26, 2021
@guunergooner
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 26, 2021
Copy link
Contributor

@hughmiao hughmiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tongchao199 , thanks for the contribution!

@@ -52,21 +52,21 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
name = "io_bazel_rules_go",
urls = [
"https://storage.googleapis.com/bazel-mirror/github.com/bazelbuild/rules_go/releases/download/v0.20.3/rules_go-v0.20.3.tar.gz",
"https://github.com/bazelbuild/rules_go/releases/download/v0.20.3/rules_go-v0.20.3.tar.gz",
"https://storage.googleapis.com/bazel-mirror/github.com/bazelbuild/rules_go/releases/download/0.17.0/rules_go-0.17.0.tar.gz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowering the io_bazel_rules_go and bazel_gazelle versions had issues to build other targets in the workspace (e.g., pip wheels, and cc). let's keep them as is for now? Please also see the background in the metadata_store/BUILD comment below.

@@ -647,3 +647,40 @@ cc_test(
"@org_tensorflow//tensorflow/core:test",
],
)

ml_metadata_go_wrap_cc(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq, will you only depend on the proto targets? if so, shall we exclude these targets?

Some background, the go libs were excluded temporarily due to the go-rules had issues with py3.8 / py3.9 integration testing images. The grpc, proto dependencies currently were introduced by TF workspace. We had a todo to reintroduce them back once drop the TF's dependency in the WORKSPACE.

@guunergooner guunergooner closed this by deleting the head repository Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants