Add visibility and features to mozc_win_build_target.

* Support pdb file generation. #codehealth PiperOrigin-RevId: 707779301
google · Dec 19, 2024 · 6b2694e · 6b2694e
1 parent 8d20ea6
commit 6b2694e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/build_defs.bzl b/src/build_defs.bzl
@@ -337,13 +337,14 @@ def mozc_win32_cc_prod_binary(
         executable_name_map = {},  # @unused
         srcs = [],
         deps = [],
+        features = None,
         linkopts = [],
         cpu = CPU.X64,
         static_crt = False,
         tags = MOZC_TAGS.WIN_ONLY,
         win_def_file = None,
         target_compatible_with = ["@platforms//os:windows"],
-        visibility = ["//visibility:public"],
+        visibility = None,
         **kwargs):
     """A rule to build production binaries for Windows.
 
@@ -359,6 +360,7 @@ def mozc_win32_cc_prod_binary(
       executable_name_map: a map from the branding name to the executable name.
       srcs: .cc files to build the executable.
       deps: deps to build the executable.
+      features: features to be passed to mozc_cc_binary.
       linkopts: linker options to build the executable.
       cpu: optional. The target CPU architecture.
       static_crt: optional. True if the target should be built with static CRT.
@@ -372,23 +374,25 @@ def mozc_win32_cc_prod_binary(
     mozc_cc_binary(
         name = target_name,
         srcs = srcs,
+        deps = deps,
+        features = features,
         linkopts = linkopts,
         linkshared = static_crt,
         tags = tags,
         target_compatible_with = target_compatible_with,
         visibility = visibility,
         win_def_file = win_def_file,
-        deps = deps,
         **kwargs
     )
 
     mozc_win_build_target(
         name = name,
-        target = target_name,
         cpu = cpu,
         static_crt = static_crt,
-        target_compatible_with = target_compatible_with,
         tags = tags,
+        target = target_name,
+        target_compatible_with = target_compatible_with,
+        visibility = visibility,
         **kwargs
     )
 

diff --git a/src/win32/tip/BUILD.bazel b/src/win32/tip/BUILD.bazel
@@ -91,6 +91,11 @@ mozc_win32_cc_prod_binary(
         "Mozc": "mozc_tip64.dll",
         "GoogleJapaneseInput": "GoogleIMEJaTIP64.dll",
     },
+    features = ["generate_pdb_file"],
+    linkopts = [
+        "/DEBUG:FULL",
+        "/PDBALTPATH:%_PDB%",
+    ],
     static_crt = True,
     tags = MOZC_TAGS.WIN_ONLY,
     target_compatible_with = ["@platforms//os:windows"],