feat: replace "skip-git" with "include-git", making git repository scanning not the default #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
=======================================
Coverage 68.43% 68.43%
=======================================
Files 183 183
Lines 17606 17606
=======================================
Hits 12049 12049
Misses 4895 4895
Partials 662 662 ☔ View full report in Codecov by Sentry. |
G-Rath
force-pushed
the
v2/skip-git-default
branch
from
f17cacf
to
c1409f3
Compare
… our osv-scanner.toml in fixtures (google#1337) Uses the new feature landed in google#1214
…ncy resolution (google#1331) Part of google#1330 No functional change is made compared to the version in `internal/manifest`, just switched to use the osv-scalibr interface. Extractors moved to lockfilescalibr as a temporary staging ground before moving to osv-scalibr.
|
Can you update the target to the v2 branch? |
…anning not the default BREAKING CHANGE: don't scan git repositories by default, replacing "--skip-git" with "--include-git"
G-Rath
force-pushed
the
v2/skip-git-default
branch
from
c1409f3
to
c0265ae
Compare
|
@oliverchang given we don't have any tests for this area of the scanner and the conflicts with the v2 branch, it might be better if someone else on the team whose more familiar with the C/C++ stuff take this up, if that's possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: don't scan git repositories by default, replacing "--skip-git" with "--include-git"
I've gone with renaming the property so it aligns with being false by default, though we could keep the existing property if we really wanted; likewise, I've also changed this for both the API and CLI as I think it makes sense to have them aligned even though we could technically have them different.
Resolves #1277
(also, I think the fact that we use
--skip-gitin our workflows is another good sign it should be disabled by default 😅)