feat: retry DML with THEN RETURN in transactions #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DML statements with a THEN RETURN clause need to be executed using the ExecuteReader method. These were normally not executed in a retry loop, as they were up until now only used for queries. Queries are executed during the first call to Reader#Read(), which meant that a retry loop was not needed for calls to ExecuteReader. DML statements with a THEN RETURN clause are executed directly, and therefore need a retry loop. This fix adds a retry loop for that, and tests for DML statements with a THEN RETURN clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DML statements with a THEN RETURN clause need to be executed using the ExecuteReader method. These were normally not executed in a retry loop, as they were up until now only used for queries. Queries are executed during the first call to Reader#Read(), which meant that a retry loop was not needed for calls to ExecuteReader. DML statements with a THEN RETURN clause are executed directly, and therefore need a retry loop.
This fix adds a retry loop for that, and tests for DML statements with a THEN RETURN clause.