perf: translate Contains to a parameterized IN query #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IN queries were automatically translated by EF Core to queries that used `IN (value1, value2, ..., valueN)`. This requires Spanner to re-compile the query for every possible permutation of the list of values. This change registers a specific SpannerInExpression that is used when a query using a fixed list of values is being generated. These queries are then translated to queries of this form: `IN UNNEST (@values)` The `@values` parameter is of type ARRAY.
olavloite
force-pushed
the
use-parameterized-in-query
branch
from
3775c57 to
64784a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN queries were automatically translated by EF Core to queries that used
IN (value1, value2, ..., valueN). This requires Spanner to re-compile the query for every possible permutation of the list of values.This change registers a specific SpannerInExpression that is used when a query using a fixed list of values is being generated. These queries are then translated to queries of this form:
IN UNNEST (@values)The
@valuesparameter is of type ARRAY.