fix: bytes field should be typed as a Buffer #1652
Open
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protobufjs uses the
$util.newBuffer
function to decode and initializebytes
protobuf fields. This makes so that most of times I see those fields coming asBuffer
s, notUint8Array
orstring
. This was already observed by other users as you can see here and here.This PR adds the
Buffer
type to the Typescript definition to take that into account.Related issues/references:
Towards googleapis/nodejs-bigquery-storage#335 and internal b/277340507
Supersedes googleapis/nodejs-bigquery-storage#336