Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use installed cmake #14857

Merged
merged 7 commits into from
Nov 22, 2024
Merged

ci: use installed cmake #14857

merged 7 commits into from
Nov 22, 2024

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Nov 22, 2024

Previously we needed to specify the cmake version as a workaround. It's no longer needed, and is causing build failures due to its old age.


This change is Reviewable

@scotthart scotthart enabled auto-merge (squash) November 22, 2024 16:34
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (000bb23) to head (a2c2473).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14857   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files        2319     2319           
  Lines      209109   209109           
=======================================
+ Hits       194630   194633    +3     
+ Misses      14479    14476    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@scotthart scotthart merged commit a89788f into main Nov 22, 2024
116 of 129 checks passed
@scotthart scotthart deleted the ci-gha-windows-cmake-update branch November 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants