Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BQTableSchemaToProtoDescriptor setting of FieldOption. #2743

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: BQTableSchemaToProtoDescriptor setting of FieldOption. #2743

merged 1 commit into from
Oct 28, 2024

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Oct 28, 2024 •
edited
Loading

This is to unblock protocol buffer version updates.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@PhongChuong
fix: BQTableSchemaToProtoDescriptor setting of FieldOption.
918b413 
This is to unblock protocol buffer version updates.
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Oct 28, 2024
@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 28, 2024
@PhongChuong PhongChuong marked this pull request as ready for review October 28, 2024 17:33
@PhongChuong PhongChuong requested a review from a team as a code owner October 28, 2024 17:33
lqiu96
lqiu96 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PhongChuong
Copy link
Contributor Author

Thanks for the reviews.

@PhongChuong PhongChuong merged commit fb57909 into main Oct 28, 2024
21 checks passed
@PhongChuong PhongChuong deleted the b376018662 branch October 28, 2024 18:06
@release-please release-please bot mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@shollyman shollyman shollyman approved these changes

@agrawal-siddharth agrawal-siddharth Awaiting requested review from agrawal-siddharth agrawal-siddharth is a code owner automatically assigned from googleapis/api-bigquery

@whuffman36 whuffman36 Awaiting requested review from whuffman36

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhongChuong @shollyman @lqiu96