Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: CONTRIBUTING.md should point to Conventional Commits guidelines #1507

Closed
wants to merge 3 commits into from
Closed

docs: CONTRIBUTING.md should point to Conventional Commits guidelines #1507

wants to merge 3 commits into from

Conversation

SimonScholz
Copy link

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1506 ☕️

@SimonScholz SimonScholz requested review from a team as code owners February 25, 2023 23:13
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Feb 25, 2023
@SimonScholz SimonScholz mentioned this pull request Feb 25, 2023
Closed
@maitrimangal maitrimangal added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 9, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 9, 2023
@alicejli alicejli added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2023
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 12, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 12, 2023
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Jun 12, 2023
@maitrimangal maitrimangal added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 12, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 12, 2023
@maitrimangal
Copy link
Member

Closing this due to merging changes that may have come after this PR was published, and now there is no further changes in this PR. Opened new PR - #1611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maitrimangal maitrimangal maitrimangal approved these changes

@alicejli alicejli alicejli approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: u Pull request is empty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CONTRIBUTING.md] Add link to Conventional Commits
4 participants
@SimonScholz @maitrimangal @alicejli @yoshi-kokoro