feat: automatically convert date/datetime/timestamps #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
alexander-fenster
approved these changes
Mar 20, 2024
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically converts DATE/DATETIME/TIMESTAMP accordingly to BigQuery Write API Docs. For doing this, we clone deep objects passed by the user, inspect each attribute to see if a Javascript Date exists, then convert to the appropriate format expect by the service side.
Still TDB if this is going to be an opt-in feature or enabled by default.
Fixes #419 #344 🦕