Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gsutil_uri property on Blob #1047

Closed
wants to merge 2 commits into from
Closed

Conversation

KrazyAC
Copy link

@KrazyAC KrazyAC commented May 23, 2023

Please review it if this request is acceptable. Thanks! @andrewsg

Pull Request

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #896 🦕

@KrazyAC KrazyAC requested review from a team as code owners May 23, 2023 04:16
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels May 23, 2023
@andrewsg
Copy link
Contributor

andrewsg commented Apr 3, 2024

Apologies for letting this sit for so long. When the PR was originally filed, we were beginning to work on support for universe domains internally, and that feature conflicted with this implementation. As non-default universe domains need to be supported going forward, I can't accept this PR as it is, but I will open a bug to track the work going forward and do my best to incorporate this idea into the final product. Thank you.

@andrewsg andrewsg closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing uri property on Blob()
3 participants