Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use native namespace to avoid pkg_resources warnings #1176

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Nov 4, 2023

Fixes #1000 🦕

@andrewsg andrewsg requested review from a team as code owners November 4, 2023 01:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Nov 4, 2023
@parthea
Copy link
Contributor

parthea commented Nov 4, 2023

Sorry I accidentally clicked the close button while I was typing..

For other google-cloud-* libraries, we'll follow the same change in googleapis/google-auth-library-python#1205 which includes switching to find_namespace_packages as described in https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages

@parthea parthea closed this Nov 4, 2023
@parthea parthea reopened this Nov 4, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 8, 2023
@andrewsg
Copy link
Contributor Author

andrewsg commented Nov 8, 2023

@parthea Thank you very much. PTAL

@andrewsg andrewsg requested a review from parthea November 8, 2023 01:09
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove namespace_packages= in setup.py and add a packaging test similar to https://github.com/googleapis/google-auth-library-python/pull/1205/files

@andrewsg
Copy link
Contributor Author

andrewsg commented Nov 8, 2023

@parthea Test will be added after dependencies are updated, see #1179 . Took care of the setup.py updates. PTAL

@parthea parthea merged commit 2ed915e into main Nov 9, 2023
5 checks passed
@parthea parthea deleted the native_namespace branch November 9, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning for pkg_resources.declare_namespace usage in google.cloud
2 participants