chore: demo offset parsing tests in java-core + java.time #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…core' into java-time-for-java-core
diegomarquezp
added
the
do not merge
diegomarquezp
commented
Nov 7, 2024
Comment on lines
+291
to
+300
| void demoAssertion1() { | ||
| assertThat(Timestamp.parseTimestampDuration("2020-07-10T14:03:00.123-07:00")) | ||
| .isEqualTo(Timestamp.ofTimeSecondsAndNanos(1594414980, 123000000)); | ||
| } | ||
|
|
||
| @Test | ||
| void demoAssertion2() { | ||
| assertThat(Timestamp.parseTimestampDuration("2020-12-06T19:21:12.123+05:30")) | ||
| .isEqualTo(Timestamp.ofTimeSecondsAndNanos(1607262672, 123000000)); | ||
| } |
There was a problem hiding this comment.
I added these two tests to separately confirm that both offset conversion test cases are failing when using appendOffsetId() using java.time in java 8
There was a problem hiding this comment.
Error: Failures:
Error: TimestampTest.demoAssertion1:293 value of: parseTimestampDuration(...)
expected: 2020-07-10T21:03:00.123000000Z
but was : 2020-07-10T14:03:00.123000000Z
Error: TimestampTest.demoAssertion2:299 value of: parseTimestampDuration(...)
expected: 2020-12-06T13:51:12.123000000Z
but was : 2020-12-06T19:21:12.123000000Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.