chore: remove protoc grpc from generation config #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
blakeli0
reviewed
Nov 22, 2024
diegomarquezp
approved these changes
Nov 25, 2024
|
I decided to keep the support of running python script directly in development guide. |
blakeli0
reviewed
Nov 25, 2024
| @@ -88,24 +88,23 @@ WORKDIR /protoc | |||
| RUN source /src/library_generation/utils/utilities.sh \ | |||
| && download_protoc "${PROTOC_VERSION}" "${OS_ARCHITECTURE}" | |||
| # we indicate protoc is available in the container via env vars | |||
| ENV DOCKER_PROTOC_LOCATION=/protoc | |||
| ENV DOCKER_PROTOC_LOCATION=/protoc/protoc/bin | |||
There was a problem hiding this comment.
Is duplicated protoc expected in the location?
There was a problem hiding this comment.
Yes.
Do you think we should reduce the duplicated directory?
There was a problem hiding this comment.
Yes, if it is not required, just protoc/bin is clearer IMO. I think we can unzip to the root folder in the line below?
blakeli0
approved these changes
Nov 25, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
protoc_versionandgrpc_versionfrom generation config.