Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

minor fixes #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

JohnRDOrazio
Copy link

Hi, I noticed a stray

element, so I removed it.
Also the same variable was being declared twice in the same scope, so I changed the second variable.
Fairly trivial changes.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@JohnRDOrazio
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1) switch between languages while speech recognition is active, and it will seemlessly update the recognition engine with the new language;
2) add speech synthesis for feedback on input
3) make the final results span editable by the user, so that it seems more like a textarea
@JohnRDOrazio
Copy link
Author

oops I should have left these first simple fixes in a separate patch branch, instead I merged them onto my master branch and initiated the pull request from the master branch; now the other changes I have merged to my master branch have been included in this pull request. No harm done, they are still useful enhancements that I put in a separate patch branch and for which I initiated another pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants