[glyphs] Clean up custom params #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
glyphs-custom-params-type
branch
from
4bbee4b
to
38264d8
Compare
anthrotype
reviewed
Nov 22, 2024
glyphs-reader/src/font.rs
Outdated
| @@ -65,6 +62,15 @@ pub struct Font { | |||
| // master id => { (name or class, name or class) => adjustment } | |||
| pub kerning_ltr: Kerning, | |||
|
|
|||
| pub custom_parameters: CustomFontParameters, | |||
There was a problem hiding this comment.
how about naming them "FontCustomParameters" instead? To my non-native Engish speaking mind, it reads slightly better as it makes it easier to compare/contrast to the other masters' and instances' custom parameters.
By the way, don't we need to also group the latter two?
There was a problem hiding this comment.
name sounds good.
And yes, the goal is also to group the other ones, I can take a look at that too.
anthrotype
reviewed
Nov 22, 2024
| .map(|v| v as f64), | ||
| ); | ||
|
|
||
| macro_rules! set_metric { |
anthrotype
approved these changes
Nov 22, 2024
cmyr
force-pushed
the
glyphs-custom-params-type
branch
from
38264d8
to
5770add
Compare
We're going to need to support a bunch of of these, and it was becoming hard to keep track of what was being handled and what wasn't. This moves all the custom params (at the font level) into a new CustomFontParameters struct. It also reduces boilerplate when these are used in glyphs2fontir. The ultimate goal here is to do smarter parsing of these custom paramaters in such a way as to be able to warn if there are any we aren't handling.
cmyr
force-pushed
the
glyphs-custom-params-type
branch
from
5770add
to
6f5c02b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to need to support a bunch of of these, and it was becoming hard to keep track of what was being handled and what wasn't. This moves all the custom params (at the font level) into a new CustomFontParameters struct.
It also reduces boilerplate when these are used in glyphs2fontir.
The ultimate goal here is to do smarter parsing of these custom paramaters in such a way as to be able to warn if there are any we aren't handling.