instructionCompiler: don't log about .notdef missing #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is just noise and may be confusing for the user. .notdef glyph is often automatically generated by ufo2ft, in which case of course it's missing from the source UFOs, there's no need for instructionCompiler to add noise to the already busy fontmake output...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep seing logging messages like this coming from ufo2ft.instructionCompiler
this is just noise and may also be confusing for the user. ".notdef" glyph is very often automatically generated by ufo2ft, in which case obviously it's because it is missing from the source UFOs, and so there's no need for the instructionCompiler to be chatty about it.