fix: fixed issue when multiple marker managers have been added, for instance in multiple clustering #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstance in multiple clustering
…nstance in multiple clustering
…nstance in multiple clustering
wangela
approved these changes
Sep 14, 2023
wangela
deleted the
fix/click_listener_with_multiple_marker_managers
branch
googlemaps-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
## [2.14.1](v2.14.0...v2.14.1) (2023-09-14) ### Bug Fixes * fixed issue when multiple marker managers have been added, for instance in multiple clustering ([#396](#396)) ([ff3f98b](ff3f98b))
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes an issue when multiple MarkerManagers are added (for instance, when we are adding multiple clusters), and only the last one is being triggered.
This has been solved by moving the execution of the invoke function within the reified
findInputCallbackfunction. The function will execute the callback click listener when we found a matching node or an input handler.--
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #294 and eventually #394