Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make example main activity scrollable to access all buttons on small screen #433

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

bubenheimer
Copy link
Contributor

@bubenheimer bubenheimer commented Oct 12, 2023

Fixes inability to access all buttons in Main Activity on a small screen

Fixes #434

@kikoso
Copy link
Collaborator

kikoso commented Oct 12, 2023

Hi @bubenheimer .

Could you rename your commit and the PR title to follow the semantic PR rules?

Ideally, creating and referring an issue would be great.

@bubenheimer bubenheimer changed the title Make example main activity scrollable to access all buttons on small screen fix: Make example main activity scrollable to access all buttons on small screen Oct 12, 2023
@bubenheimer bubenheimer changed the title fix: Make example main activity scrollable to access all buttons on small screen fix: make example main activity scrollable to access all buttons on small screen Oct 12, 2023
@bubenheimer
Copy link
Contributor Author

Thanks @kikoso I've updated commit message & PR title

All it does is make the main Activity buttons of the example vertically scrollable because I can't access the bottommost button on the smallest supported emulator screen size. Shouldn't need a dedicated issue I'd think.

@kikoso
Copy link
Collaborator

kikoso commented Oct 12, 2023

@bubenheimer , we typically like to keep issues for indexing purposes, i.e., generally folks tend to find existing problems (ideally) in the issues section, so we can avoid duplicates.

I am checking it with smaller devices and it looks good so far!

@bubenheimer
Copy link
Contributor Author

Fixes #434

@bubenheimer
Copy link
Contributor Author

@kikoso @wangela Is there anything that stands in the way of this being merged now? I can re-push once you are ready to merge.

@wangela
Copy link
Member

wangela commented Oct 28, 2023

I'm gonna mark this a chore because it's only a change to the demo app and shouldn't trigger a new release for the library.

@wangela wangela merged commit 52d0342 into googlemaps:main Oct 28, 2023
7 of 8 checks passed
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bubenheimer bubenheimer deleted the make_menu_scroll branch November 27, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples app: cannot access all buttons on small screen
4 participants