-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make example main activity scrollable to access all buttons on small screen #433
Conversation
Hi @bubenheimer . Could you rename your commit and the PR title to follow the semantic PR rules? Ideally, creating and referring an issue would be great. |
262a02a
to
e2a812d
Compare
Thanks @kikoso I've updated commit message & PR title All it does is make the main Activity buttons of the example vertically scrollable because I can't access the bottommost button on the smallest supported emulator screen size. Shouldn't need a dedicated issue I'd think. |
@bubenheimer , we typically like to keep issues for indexing purposes, i.e., generally folks tend to find existing problems (ideally) in the issues section, so we can avoid duplicates. I am checking it with smaller devices and it looks good so far! |
Fixes #434 |
I'm gonna mark this a |
🎉 This PR is included in version 4.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fixes inability to access all buttons in Main Activity on a small screen
Fixes #434