Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added StreetViewUtil sample #435

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Oct 13, 2023

This PR provides an in-app sample to manage invalid locations in Street View.

#265


  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #265 🦕

@kikoso kikoso force-pushed the chore/added_street_view_utils_sample branch from 52ecb19 to b69bea6 Compare October 20, 2023 16:23
@wangela
Copy link
Member

wangela commented Oct 21, 2023

@kikoso, to avoid making the developer have to install an explicit dependency on android-maps-utils to get the StreetViewUtil metadata check, which may conflict with the dependency on maps-compose-utils that pulls in android-maps-utils, we should make sure it's clear that the developer should install maps-compose-utils if they want to use Street View and its Util metdata check.

Does anything need to be added to maps-compose-utils and/or its README in order to get the StreetViewUtil for use in Compose apps? I see the app-level build.gradle in the demo app is getting the metadata utility from maps-compose-utils.

@wangela
Copy link
Member

wangela commented Oct 21, 2023

Suggested an edit to the README based on my understanding that the developer just needs to add maps-compose-utils. If that LGTY, seems like no need to add any code to the Maps Compose Utility Library. If that matches your understanding, we can merge this.

@wangela
Copy link
Member

wangela commented Oct 21, 2023

n.b. maps-compose-utils supports Street View Metadata Utility as of v3.0.0 which pulls in maps-utils-ktx v4.0.0 which is the earliest release that pulls in android-maps-utils v3.5.3 that added the metadata utility in v3.5.0.

Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 questions for you

@wangela wangela merged commit f7a2e18 into main Oct 25, 2023
10 checks passed
@wangela wangela deleted the chore/added_street_view_utils_sample branch October 25, 2023 17:54
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreetView Composable crashes with some locations
3 participants