Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed clustering recomposition #458

Closed
wants to merge 1 commit into from

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Nov 13, 2023

The following PR fixes an issue where clusters were not being removed from the map after going through a recomposition.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #397 🦕

@kikoso
Copy link
Collaborator Author

kikoso commented Nov 23, 2023

Fixed in #421

@kikoso kikoso closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster does not get removed
2 participants