docs: improved recomposition sample #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubenheimer
reviewed
Dec 14, 2023
There was a problem hiding this comment.
@kikoso Thank you for revisiting this. The sample code looks good to me. I've added a couple comments to try and make the documentation easier to grasp.
bubenheimer
approved these changes
Dec 15, 2023
kikoso
changed the title
wangela
requested changes
Dec 15, 2023
app/src/main/java/com/google/maps/android/compose/RecompositionActivity.kt
Outdated
Show resolved
Hide resolved
wangela
requested changes
Dec 20, 2023
bubenheimer
reviewed
Jan 15, 2024
bubenheimer
reviewed
Jan 15, 2024
app/src/main/java/com/google/maps/android/compose/RecompositionActivity.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Uli Bubenheimer <[email protected]>
Co-authored-by: Uli Bubenheimer <[email protected]>
wangela
requested changes
Jan 22, 2024
wangela
approved these changes
Jan 22, 2024
|
🎉 This PR is included in version 4.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the recomposition sample to showcase a better usage of location within the MarkerState.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #448 🦕