Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated Compose, Kotlin and AGP #511

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Jan 25, 2024

The current PR updates the Compose BoM, Kotlin and AGP after the latest Compose release.

The strong skipping mode is still not included as it is experimental, but it is under evaluation.

@kikoso kikoso added the type: cleanup An internal cleanup or hygiene concern. label Jan 25, 2024
@bubenheimer
Copy link
Contributor

bubenheimer commented Jan 25, 2024

@kikoso I have a PR waiting that makes the immutable data types from Google Play Maps @Stable. I will submit it once this PR is merged, or your other PR that raises compose-compiler past 1.5.3.

Making immutable data types @Stable can be a more effective measure than relying on strong skipping, as stable types can use structural equality, whereas strong skipping merely relies on referential equality, as of today.

Strong skipping will still be useful to make things that are not immutable a little more performant.

@kikoso
Copy link
Collaborator Author

kikoso commented Jan 25, 2024

Thanks @bubenheimer ! Looking forward.

@bubenheimer
Copy link
Contributor

Oops, I missed the recent compiler update to 1.5.4 on main. Will submit my PR soon.

@wangela wangela merged commit 26ec87e into main Jan 26, 2024
11 checks passed
@wangela wangela deleted the chore/updated_compose branch January 26, 2024 17:09
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 4.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants