fix: add stability configuration file to the core maps-compose projec… #517
Conversation
…t. The currently configured types are all the immutable data types from com.google.android.gms.maps.model that are currently used in android-maps-compose:maps-compose. These types will now be considered @stable by the compiler. Making immutable data types @stable can be a more effective measure than relying on strong skipping, as stable types can use structural equality, whereas strong skipping merely relies on referential equality, as of today. This commit also makes compose compiler report generation available via command-line options (-PcomposeCompilerMetrics=true, -PcomposeCompilerReports=true) Fixes googlemaps#152
|
@kikoso are you open to reviewing this PR? |
|
@wangela can this PR receive a review, please? |
|
Hi @bubenheimer . Thanks for the PR, and for the patience while getting this reviewed. This should improve the stability and performance. Is there a reason why you would not include the other types in the |
|
@kikoso The types in I've validated for the types in the stability configuration file that they are immutable. These are all the Maps SDK model types currently in use in the maps-compose library. I did not look at what's being used in maps-compose-utils, and did not provide a stability configuration file there, as I don't use that lib, not familiar with it. It can be done independently of this PR. |
|
@kikoso Actually, |
|
Thanks @bubenheimer , that makes sense. We will wait until the strong skipping mode exits its experimental phase before adopting it. However, this already represents an improvement in terms of performance. |
## [4.3.4](v4.3.3...v4.3.4) (2024-04-16) ### Bug Fixes * add stability configuration file to the core maps-compose project. The currently configured types are all the immutable data types from com.google.android.gms.maps.model that are currently used in android-maps-compose:maps-compose. These types will now be considered @stable by the compiler. Making immutable data types @stable can be a more effective measure than relying on strong skipping, as stable types can use structural equality, whereas strong skipping merely relies on referential equality, as of today. ([#517](#517)) ([bfe95dd](bfe95dd)), closes [#152](#152)
|
🎉 This PR is included in version 4.3.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…t. The currently configured types are all the immutable data types from com.google.android.gms.maps.model that are currently used in android-maps-compose:maps-compose. These types will now be considered @stable by the compiler. Making immutable data types @stable can be a more effective measure than relying on strong skipping, as stable types can use structural equality, whereas strong skipping merely relies on referential equality, as of today.
This commit also makes compose compiler report generation available via command-line options (-PcomposeCompilerMetrics=true, -PcomposeCompilerReports=true)
Fixes #152