-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: recomposition demo, updates Camera #544
base: main
Are you sure you want to change the base?
Conversation
…tre the camera view when the location changes
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I have signed the CLA |
Hello and thanks for the PR, @CaolanCode ! I have updated the title to follow the semantic PR specification. Could you please update your commit name to follow the following convention? |
Hi @CaolanCode . Did you manage to see the previous message? |
…se into caolancode
Hi @kikoso, thanks for the message. I've updated the sematics of the PR. |
Hello,
In the recomposition demonstration the camera position is not updated with the marker position.
I have updated the camera position when the marker position is changed.
I've also used the location "signapore4" as it wasn't used.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕