Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: standalone classic mapview #181

Merged
merged 18 commits into from
Oct 29, 2024
Merged

feat: standalone classic mapview #181

merged 18 commits into from
Oct 29, 2024

Conversation

illuminati1911
Copy link
Contributor

@illuminati1911 illuminati1911 commented Oct 14, 2024 •
edited by jokerttu
Loading

Implement separate regular Google Map View that can be used without navigation.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@illuminati1911 illuminati1911 force-pushed the feature/standalone-mapview branch from 4f09124 to 370579c Compare October 14, 2024 15:31
@illuminati1911 illuminati1911 force-pushed the feature/standalone-mapview branch from 154654e to d39c342 Compare October 16, 2024 06:48
jokerttu
jokerttu requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still quite a lot navigation related comments and methods in new maps controller and view.
Also view wrapper should be used on native code to detect the maps size on inialization properly.

ios/Classes/GoogleMapsNavigationView.swift Show resolved Hide resolved
lib/src/google_maps_map_view.dart Outdated Show resolved Hide resolved
lib/src/google_maps_map_view.dart Outdated Show resolved Hide resolved
lib/src/google_maps_map_view.dart Outdated Show resolved Hide resolved
lib/src/google_maps_map_view.dart Outdated Show resolved Hide resolved
lib/src/google_maps_map_view_controller.dart Outdated Show resolved Hide resolved
lib/src/google_maps_map_view_controller.dart Outdated Show resolved Hide resolved
@illuminati1911
Copy link
Contributor Author

Updated comments, dart doc and variables regarding new map view on flutter side.

@illuminati1911 illuminati1911 marked this pull request as ready for review October 24, 2024 08:17
@illuminati1911 illuminati1911 changed the title feat: standalone classic mapview WIP feat: standalone classic mapview Oct 24, 2024
jokerttu
jokerttu requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some areas to fix.
It would be important to add integration tests for both map types in areas where both implement same features, as native implmentaton might have bugs (as in Android getNavigationView method is used for map view methods)

android/src/main/kotlin/com/google/maps/flutter/navigation/GoogleMapsViewMessageHandler.kt Outdated Show resolved Hide resolved
lib/src/method_channel/common_view_api.dart Show resolved Hide resolved
lib/src/method_channel/common_view_api.dart Outdated Show resolved Hide resolved
android/src/main/kotlin/com/google/maps/flutter/navigation/GoogleMapsViewMessageHandler.kt Outdated Show resolved Hide resolved
lib/google_navigation_flutter.dart Show resolved Hide resolved
lib/src/google_maps_map_view.dart Outdated Show resolved Hide resolved
lib/src/google_maps_map_view.dart Show resolved Hide resolved
lib/src/google_maps_map_view_controller.dart Outdated Show resolved Hide resolved
@illuminati1911 illuminati1911 force-pushed the feature/standalone-mapview branch from a76b559 to c59c051 Compare October 28, 2024 09:49
jokerttu
jokerttu requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review comments.
Looks good after these comments are addressed

android/src/main/kotlin/com/google/maps/flutter/navigation/GoogleMapsNavigationPlugin.kt Outdated Show resolved Hide resolved
android/src/main/kotlin/com/google/maps/flutter/navigation/GoogleMapsViewMessageHandler.kt Outdated Show resolved Hide resolved
android/src/main/kotlin/com/google/maps/flutter/navigation/GoogleMapsNavigationView.kt Outdated Show resolved Hide resolved
android/src/main/kotlin/com/google/maps/flutter/navigation/GoogleMapsViewRegistry.kt Show resolved Hide resolved
dartdoc_options.yaml Outdated Show resolved Hide resolved
example/integration_test/shared.dart Show resolved Hide resolved
example/integration_test/shared.dart Show resolved Hide resolved
example/integration_test/t06_map_test.dart Outdated Show resolved Hide resolved
jokerttu
jokerttu approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can be merged after tests pass with improved test structure

@illuminati1911 illuminati1911 force-pushed the feature/standalone-mapview branch from ab75ec0 to d2fb731 Compare October 29, 2024 09:53
@illuminati1911 illuminati1911 merged commit e85f590 into main Oct 29, 2024
14 of 15 checks passed
@illuminati1911 illuminati1911 deleted the feature/standalone-mapview branch October 29, 2024 11:43
@googlemaps-bot googlemaps-bot mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokerttu jokerttu jokerttu approved these changes

Assignees

@jokerttu jokerttu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illuminati1911 @jokerttu