Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Implementation smells #937

Closed
wants to merge 8 commits into from
Closed

Fix Implementation smells #937

wants to merge 8 commits into from

Conversation

AmanDesai10
Copy link

@AmanDesai10 AmanDesai10 commented Nov 28, 2023 •
edited
Loading

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #938 🦕

I have also added few test cases so the test coverage is also improved.

@AmanDesai10 AmanDesai10 requested a review from a team as a code owner November 28, 2023 00:04
@AmanDesai10 AmanDesai10 requested a review from wangela November 28, 2023 00:04
@AmanDesai10 AmanDesai10 changed the title Fix design smells Fix Implementation smells Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangela wangela Awaiting requested review from wangela wangela is a code owner automatically assigned from googlemaps/admin

Assignees

@amuramoto amuramoto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple Implementation Smells Present
2 participants
@AmanDesai10 @amuramoto