Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing type administrative_area_level_6 and administrative_area_level_7 #986

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add missing type administrative_area_level_6 and administrative_area_level_7 #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/com/google/maps/model/AddressComponentType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ public enum AddressComponentType {
*/
ADMINISTRATIVE_AREA_LEVEL_5("administrative_area_level_5"),

/**
* A sixth-order civil entity below the country level. This type indicates a minor civil division.
* Not all nations exhibit these administrative levels.
*/
ADMINISTRATIVE_AREA_LEVEL_6("administrative_area_level_6"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such changes should also be included at AddressType file as well.


/**
* A seventh-order civil entity below the country level. This type indicates a minor civil division.
* Not all nations exhibit these administrative levels.
*/
ADMINISTRATIVE_AREA_LEVEL_7("administrative_area_level_7"),

/** A commonly-used alternative name for the entity. */
COLLOQUIAL_AREA("colloquial_area"),

Expand Down
2 changes: 2 additions & 0 deletions src/test/java/com/google/maps/model/EnumsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ public void testCanonicalLiteralsForAddressComponentType() {
m.put(AddressComponentType.ADMINISTRATIVE_AREA_LEVEL_3, "administrative_area_level_3");
m.put(AddressComponentType.ADMINISTRATIVE_AREA_LEVEL_4, "administrative_area_level_4");
m.put(AddressComponentType.ADMINISTRATIVE_AREA_LEVEL_5, "administrative_area_level_5");
m.put(AddressComponentType.ADMINISTRATIVE_AREA_LEVEL_6, "administrative_area_level_6");
m.put(AddressComponentType.ADMINISTRATIVE_AREA_LEVEL_7, "administrative_area_level_7");
m.put(AddressComponentType.COLLOQUIAL_AREA, "colloquial_area");
m.put(AddressComponentType.LOCALITY, "locality");
m.put(AddressComponentType.WARD, "ward");
Expand Down